Fix tracker promise from throwing when set multiple times #235
Conversation
| template <typename BufferType, typename Allocator> | ||
| size_t BufferedProducer<BufferType, Allocator>::get_buffer_size() const { | ||
| return messages_.size() + retry_messages_.size(); | ||
| int size = 0; |
mfontanini
left a comment
mfontanini
left a comment
There was a problem hiding this comment.
This class has become hell, I don't even know what's happening in here anymore. I'll trust you that this fixes a problem and is not potentially hiding another one.
|
Yes it has gotten a bit out of hand with too many features instead of keeping a strict delineation of functionality and split it into smaller classes. The class API however is quite clean so that's always good. I may revisit the inner implementation the future or perhaps bring back the original design under some other name and keep this one as-is (if you want). Not too many use it so hopefully it's not causing instability elsewhere. |
|
Yeah, the admin API should be the next thing although I probably won't for on that in the near future. |
2 participants
Two issues:
std::deque::size()should be guarded as it's not thread safe. The size() is computed via pointer diff (finish-start) of the queue itself and it returns garbage in a multi-threaded access scenario.promise_already_satisfiedexception. This in itself is not an error, however it prevents thepending_acksfrom being properly decremented and the flush eventually blocks forever as thepending_acksmismatch.@mfontanini please prioritize this if you can. Much appreciated!!